only assign XLS numbers after a maintainer's approval#483
only assign XLS numbers after a maintainer's approval#483
Conversation
There was a problem hiding this comment.
Pull request overview
This PR modifies the XLS number assignment workflow to require maintainer approval before assigning an XLS number to new proposals. Previously, the workflow triggered automatically when PRs were opened or updated. The change aims to provide better control over the assignment process by ensuring only approved proposals receive XLS numbers.
Changes:
- Modified workflow trigger from
pull_request_target(on open/sync/reopen/ready_for_review) topull_request_review(on review submission) - Added conditional check to only run workflow when review state is "approved"
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
High Level Overview of Change
Title says it all
Context of Change
Better management - otherwise anyone can get an XLS number assigned to them
Type of Change